Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proxy-rewrite plugin's execution phase should change from rewrite to access #10965

Closed
qihaiyan opened this issue Feb 26, 2024 · 5 comments
Labels
doc Documentation things

Comments

@qihaiyan
Copy link
Contributor

Description

According to the document

In APISIX, only the authentication logic can be run in the rewrite phase

proxy-rewrite isn't an authentication plugin, so should be run in the access phase

@shreemaan-abhishek
Copy link
Contributor

the document is inaccurate here.

@shreemaan-abhishek shreemaan-abhishek added the doc Documentation things label Feb 26, 2024
@kayx23
Copy link
Member

kayx23 commented Feb 26, 2024

@shreemaan-abhishek please suggest a fix or help opening a PR, thanks.

And update the title of this issue accordingly.

@qihaiyan
Copy link
Contributor Author

image
According to the openresty's run phases, the proxy-rewrite is used to change the request to upstream, so i think change the proxy-rewrite's run phase to access phase is more suitable.

@shreemaan-abhishek
Copy link
Contributor

please suggest a fix or help opening a PR, thanks.

I opened a PR.

@shreemaan-abhishek
Copy link
Contributor

closing in favor of #10973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation things
Projects
Archived in project
Development

No branches or pull requests

3 participants