Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support etcd v3 #1767

Closed
membphis opened this issue Jun 24, 2020 · 7 comments
Closed

feature: support etcd v3 #1767

membphis opened this issue Jun 24, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@membphis
Copy link
Member

related issues:

https://github.com/apache/incubator-apisix/issues?q=is%3Aissue+is%3Aopen+v3+

lua-resty-etcd already supports etcd v3, we can support it by this feature:

https://github.com/api7/lua-resty-etcd/blob/master/api_v3.md

@membphis membphis added the enhancement New feature or request label Jun 24, 2020
@shenal
Copy link
Contributor

shenal commented Jun 24, 2020

Current data access logic does not encapsulate the internal fields set by etcd. While we tackle the v3 upgrade we should have a separate data access layer which abstracts the internal etcd API requirements and act purely as a K/V layer. This will not only help us tackle similar upgrades but also will enable us easily allow different datastores without changes to the business logic

@shenal
Copy link
Contributor

shenal commented Jun 26, 2020

@membphis I would like to start work on this. If no one is planning to pick this up

@membphis
Copy link
Member Author

that is great, I have assigned to you ^_^

@nic-chen
Copy link
Member

@shenal @membphis
support etcd v3 is a task of summer2020( #1542 ), I think @Yiyiyimu is working on it already. You could give your advice to him, and help review when he submit pr : )

@Yiyiyimu What is your progress now ? Maybe you could submit a draft pr So we could see your progress.

@shenal
Copy link
Contributor

shenal commented Jun 27, 2020

@nic-chen Perfect !! :)

@Yiyiyimu Let me know how I can help

@Yiyiyimu
Copy link
Member

Hi @shenal thank you for your help! I'll submit the draft pr these days and I'll let you know whenever a discussion is needed~

@spacewander
Copy link
Member

Solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants