Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: “prevNode” should not return after setting a route #2204

Closed
idbeta opened this issue Sep 10, 2020 · 2 comments
Closed

bug: “prevNode” should not return after setting a route #2204

idbeta opened this issue Sep 10, 2020 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@idbeta
Copy link
Contributor

idbeta commented Sep 10, 2020 •
edited

Issue description

set twice route in the same uri，the second response should not include “preNode”
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
...
{"action":"set","node":{...},"prevNode":{...}}

Environment

  • apisix version (cmd: apisix version): 1.5
  • OS: centos7
@moonming moonming added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 10, 2020
@moonming
Copy link
Member

yes, agreed, we can remove the prevNode section now.
Welcome PR

@idbeta
Copy link
Contributor Author

idbeta commented Oct 29, 2020

it was fixed in v2.0

@idbeta idbeta closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@idbeta @moonming