-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: log-rotate can not rotate logs strictly hourly(or minutely) #6517
Comments
What problem does this solve? Also I don't think this is a bug |
need @shuaijinchao's help |
Strictly hourly rotation of logs is better |
@snowdusk Sorry, this is a problem caused by one of my previous PRs. Aligning time avoids fragmented logs in case of restarts etc. during rotation time, so the solution you provided would be better. Are you interested in fixing it? |
@shuaijinchao OK. I will create a PR |
Issue description
e.g.
Apisix start time is 15:29:23, log-rotate interval is 3600(1 hour)
Next rotate time is 16:29:23, next next rotate time is 17:29:23
I want next rotate time is 16:00:00, next next rotate time is 17:00:00
The current implement:
This is my change.
The text was updated successfully, but these errors were encountered: