Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add consumer, route, service ID as key for limit-rate, limit-count, limit-conn #93

Closed
moonming opened this issue Jun 14, 2019 · 3 comments
Closed

add consumer, route, service ID as key for limit-rate, limit-count, limit-conn #93

moonming opened this issue Jun 14, 2019 · 3 comments

Comments

@moonming
Copy link
Member

now we only support IP as key, which is not enough
@moonming moonming added this to the 0.5 milestone Jun 14, 2019
@membphis
Copy link
Member

I recommend implementing it in the 0.6 version.

@membphis membphis removed this from the 0.5 milestone Jun 15, 2019
@moonming moonming mentioned this issue Jul 1, 2019
Closed
@moonming moonming added this to the 0.6 milestone Jul 4, 2019
@moonming moonming modified the milestones: 0.6, 0.7 Jul 18, 2019
@moonming moonming reopened this Jul 21, 2019
@moonming moonming changed the title add consumer, route, service as key for limit-rate, limit-count, limit-conn add consumer, route, service ID as key for limit-rate, limit-count, limit-conn Jul 21, 2019
@moonming
Copy link
Member Author 

local key = ip .. '&' .. ctx.conf_version .. '&' .. api_ctx.conf_type .. '&' .. api_ctx.conf_id

@moonming
Copy link
Member Author

fixed by 8c5d5d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plugin more key moonming/apisix
2 participants
@membphis @moonming