stride arg of array_slice() should be optional

[yutannihilation]

Describe the bug

Currently, all args of array_slice() is mandatory, but stride seems optional.

https://docs.rs/datafusion/38.0.0/datafusion/functions_array/expr_fn/fn.array_slice.html:

pub fn array_slice(array: Expr, begin: Expr, end: Expr, stride: Expr) -> Expr

code:

datafusion/datafusion/functions-array/src/extract.rs

Lines 296 to 305 in 09dde27

	let args_len = args.len();
	if args_len != 3 && args_len != 4 {
	return exec_err!("array_slice needs three or four arguments");
	}
	let stride = if args_len == 4 {
	Some(as_int64_array(&args[3])?)
	} else {
	None
	};

To Reproduce

n/a

Expected behavior

n/a

Additional context

n/a

[jonahgao]

Hi @yutannihilation , this has been fixed on the main branch.

datafusion/datafusion/functions-array/src/extract.rs

Lines 224 to 231 in 09dde27

	#[doc = "returns a slice of the array."]
	pub fn array_slice(array: Expr, begin: Expr, end: Expr, stride: Option<Expr>) -> Expr {
	let args = match stride {
	Some(stride) => vec![array, begin, end, stride],
	None => vec![array, begin, end],
	};
	array_slice_udf().call(args)
	}

[yutannihilation]

Oh, great! Sorry that I didn't look at the latest code. I'm closing.