Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Hyperloglog to UDAF #10944

Closed
jayzhan211 opened this issue Jun 17, 2024 · 3 comments
Closed

Convert Hyperloglog to UDAF #10944

jayzhan211 opened this issue Jun 17, 2024 · 3 comments
Assignees
@dharanad
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jayzhan211
Copy link
Contributor

Is your feature request related to a problem or challenge?

Similar to other issues in #8708

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@jayzhan211 jayzhan211 added enhancement New feature or request good first issue Good for newcomers labels Jun 17, 2024
@dharanad
Copy link
Contributor

take

@dharanad
Copy link
Contributor

Hey @jayzhan211
I noticed the approx_distinct UDAF implemented in datafusion/functions-aggregate/src/approx_distinct.rs. It appears to be using a HyperLogLog (HLL) structure defined in datafusion/functions-aggregate/src/hyperloglog.rs.

What is the expected outcome of this issue. Could you provide some insights into the intended use of this UDAF?

@jayzhan211
Copy link
Contributor Author

yeah, I didn't take a look carefully, we actually don't need this. Let me close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dharanad dharanad

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dharanad @jayzhan211