Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The unary_scalar_expr macro is used on functions that require several arguments #1173

Closed
j-a-m-l opened this issue Oct 24, 2021 · 0 comments · Fixed by #1430
Closed

The unary_scalar_expr macro is used on functions that require several arguments #1173

j-a-m-l opened this issue Oct 24, 2021 · 0 comments · Fixed by #1430
Labels
bug Something isn't working

Comments

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Oct 24, 2021

Describe the bug
The unary_scalar_expr macro is used on functions that require several arguments, so those functions fail always.

To Reproduce

df.select(vec![
    replace(&[col("number"), lit(","), lit(".")])
])

It fails with:

expected enum `Expr`, found `&[Expr; 3]`

Expected behavior
I'd expect that those functions work correctly.

Additional context
That macro also adds this comment: this scalar function is not documented yet.

Proposal
I'd create a new macro for functions that could receive several arguments.
Ideally that macro would reuse the comment of the "real" function, but that would be very involved probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant