Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datafusion-physical-expr compatible with blake3/traits-preview feature. #4784

Merged
merged 1 commit into from Jan 2, 2023

Conversation

BoredPerson
Copy link
Contributor

Which issue does this PR close?

Closes #4781.

What changes are included in this PR?

Makes datafusion-physical-expr compatible with blake3/traits-preview feature.

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-expr Physical Expressions label Dec 31, 2022
@alamb
Copy link
Contributor

alamb commented Jan 1, 2023

Thanks @BoredPerson -- if this PR passes CI it looks good to me

@alamb alamb requested a review from Jimexist January 1, 2023 13:45
@alamb alamb merged commit ad96d41 into apache:master Jan 2, 2023
@ursabot
Copy link

ursabot commented Jan 2, 2023

Benchmark runs are scheduled for baseline = bf48122 and contender = ad96d41. ad96d41 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datafusion-physical-expr doesn't compile when blake3/traits-preview is enabled
3 participants