Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make UDFs in datafusion-functions public #9584

Closed
alamb opened this issue Mar 12, 2024 · 0 comments · Fixed by #9585
Closed

make UDFs in datafusion-functions public #9584

alamb opened this issue Mar 12, 2024 · 0 comments · Fixed by #9585
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Mar 12, 2024

Is your feature request related to a problem or challenge?

We have a special wrapper over to_timestamp that has influxdb specific semantics, but falls back to the built in implementation of to_timestamp.

Now that to_timestamp has been extracted from the core, the only way I could find this UDF was by checking by name

   // Find DataFusion's built in to_timestamp implementation
   let fallback = datafusion::functions::datetime::functions()
     .into_iter()
     .find(|f| f.name() == "to_timestamp")
     .expect("to_timestamp function not found"),

Describe the solution you'd like

It would be nice if I could simply get the to_timestamp function directly as I know exactly what implementation I want, but I can't as it is not pub

Describe alternatives you've considered

No response

Additional context

No response

@alamb alamb added the enhancement New feature or request label Mar 12, 2024
@alamb alamb self-assigned this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant