New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine Serde for Scalar Function #9699

Closed

yyy1000 opened this issue Mar 19, 2024 · 1 comment

Assignees

Labels

Contributor

yyy1000 commented Mar 19, 2024

Is your feature request related to a problem or challenge?

This is a follow-up for #9436
I have thought two possible refinements:

See Support Serde for ScalarUDF in Physical Expressions #9436 (comment), we don't need ExecutionProps now and we can remove it. Also it seems a TODO before https://github.com/apache/arrow-datafusion/blob/09747596fd75bfce8903e86472cccb8acc524453/datafusion/proto/src/physical_plan/from_proto.rs#L348-L357
Support Serde for ScalarUDF in Physical Expressions #9436 (comment), we can use ScalarUDF to replace ScalarFunctionDefinition, and this must wait on [Epic] Port BuiltInFunctons to datafusion-functions-* crates #9285

Describe the solution you'd like

I think currently I can finish the first refinement, but it can also be done after all functions are ported.

Describe alternatives you've considered

No response

Additional context

No response

The text was updated successfully, but these errors were encountered:

yyy1000 added the enhancement label

Contributor Author

yyy1000 commented Mar 19, 2024

take

github-actions bot assigned yyy1000

yyy1000 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment