Implement constant folding for CAST #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
approved these changes
Jun 5, 2021
Dandandan
reviewed
Jun 5, 2021
| data_type, | ||
| } => match inner.as_ref() { | ||
| Expr::Literal(val) => { | ||
| let scalar_array = val.to_array(); |
There was a problem hiding this comment.
Great idea👍 I think converting to an array is the best we can do for now, without duplicating the code.
alamb
reviewed
Jun 6, 2021
| .build() | ||
| .unwrap(); | ||
|
|
||
| let expected = "Projection: Int32(0)\ |
There was a problem hiding this comment.
this is beautiful ❤️ -- thank you @msathis
| .build() | ||
| .unwrap(); | ||
|
|
||
| let expected = "Projection: Int32(NULL)\ |
houqp
added
datafusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #417.
Rationale for this change
Optimize cast function during planning stage
What changes are included in this PR?
Optimize cast function during planning stage
Are there any user-facing changes?
N/A