Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error handling and boundary checking for window frames #530

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 10, 2021

Which issue does this PR close?

Closes #529
Closes #528

Rationale for this change

What changes are included in this PR?

  1. add boundary case checking for window frames
  2. remove stale window frame implementations in physical planner (possibly due to rebase error)

Are there any user-facing changes?

@codecov-commenter
Copy link

Codecov Report

Merging #530 (2f60903) into master (d5bca0e) will increase coverage by 0.04%.
The diff coverage is 83.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   76.03%   76.07%   +0.04%     
==========================================
  Files         157      156       -1     
  Lines       26990    26923      -67     
==========================================
- Hits        20521    20483      -38     
+ Misses       6469     6440      -29     
Impacted Files Coverage Δ
...sta/rust/core/src/serde/logical_plan/from_proto.rs 35.04% <0.00%> (-0.17%) ⬇️
datafusion/src/physical_plan/mod.rs 78.70% <ø> (ø)
datafusion/src/logical_plan/window_frames.rs 87.87% <85.00%> (+1.27%) ⬆️
datafusion/src/sql/planner.rs 84.85% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5bca0e...2f60903. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jimexist -- thanks

@alamb alamb merged commit 77775b7 into apache:master Jun 10, 2021
@jimexist jimexist deleted the optimize-window-frames branch June 10, 2021 15:17
@jimexist
Copy link
Member Author

Looks great @jimexist -- thanks

yeah window functions are hard

@houqp houqp added datafusion Changes in the datafusion crate enhancement New feature or request labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
4 participants