Test for parquet pruning disabling #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
houqp
reviewed
Jul 19, 2021
| .await | ||
| .query(query) | ||
| .await; | ||
| println!("{}", output.description()); |
There was a problem hiding this comment.
is this print needed for the test?
There was a problem hiding this comment.
It is not needed for the test -- it is included in all of the tests in this module for debugging assistance (when the test fails a log of what is going on also is dumped). I can remove it if you prefer
There was a problem hiding this comment.
cool, just wanted to make sure it's intentional :)
houqp
approved these changes
Jul 19, 2021
|
This test looks great to me. I would add more test cases in the following PR. Thank you @alamb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Re #723
Rationale for this change
Tests are good!
What changes are included in this PR?
Add a end to end test for the config flag added in #749
Are there any user-facing changes?
No