Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrowTypes as standalone package doesn't interoperate with Arrow.ArrowTypes #209

Closed
ericphanson opened this issue Jun 3, 2021 · 3 comments · Fixed by #212
Closed

ArrowTypes as standalone package doesn't interoperate with Arrow.ArrowTypes #209

ericphanson opened this issue Jun 3, 2021 · 3 comments · Fixed by #212

Comments

@ericphanson
Copy link
Member

I think Arrow should probably depend on ArrowTypes, not directly include it's code. The following shows that we have two separate modules with separate functions, e.g. toarrow:

julia> import Arrow

julia> import ArrowTypes

julia> Arrow.ArrowTypes
Arrow.ArrowTypes

julia> Arrow.ArrowTypes == ArrowTypes
false

julia> Arrow.ArrowTypes.toarrow == ArrowTypes.toarrow
false

julia> Arrow.ArrowTypes.toarrow() = 1

julia> methods(Arrow.ArrowTypes.toarrow)
# 12 methods for generic function "toarrow":
[1] toarrow() in Main at REPL[8]:1
[2] toarrow(::Nothing) in Arrow.ArrowTypes at /Users/eph/.julia/packages/Arrow/k23fl/src/ArrowTypes/src/ArrowTypes.jl:168
[3] toarrow(x::Char) in Arrow.ArrowTypes at /Users/eph/.julia/packages/Arrow/k23fl/src/ArrowTypes/src/ArrowTypes.jl:181
[4] toarrow(x::Symbol) in Arrow.ArrowTypes at /Users/eph/.julia/packages/Arrow/k23fl/src/ArrowTypes/src/ArrowTypes.jl:203
[5] toarrow(x::AbstractSet) in Arrow.ArrowTypes at /Users/eph/.julia/packages/Arrow/k23fl/src/ArrowTypes/src/ArrowTypes.jl:215
[6] toarrow(x::Base.UUID) in Arrow.ArrowTypes at /Users/eph/.julia/packages/Arrow/k23fl/src/ArrowTypes/src/ArrowTypes.jl:230
[7] toarrow(x::Dates.Date) in Arrow at /Users/eph/.julia/packages/Arrow/k23fl/src/eltypes.jl:208
[8] toarrow(x::Dates.Time) in Arrow at /Users/eph/.julia/packages/Arrow/k23fl/src/eltypes.jl:242
[9] toarrow(x::Dates.DateTime) in Arrow at /Users/eph/.julia/packages/Arrow/k23fl/src/eltypes.jl:291
[10] toarrow(x::TimeZones.ZonedDateTime) in Arrow at /Users/eph/.julia/packages/Arrow/k23fl/src/eltypes.jl:300
[11] toarrow(x::P) where P<:Dates.Period in Arrow at /Users/eph/.julia/packages/Arrow/k23fl/src/eltypes.jl:374
[12] toarrow(x) in Arrow.ArrowTypes at /Users/eph/.julia/packages/Arrow/k23fl/src/ArrowTypes/src/ArrowTypes.jl:83

julia> methods(ArrowTypes.toarrow)
# 6 methods for generic function "toarrow":
[1] toarrow(::Nothing) in ArrowTypes at /Users/eph/.julia/packages/ArrowTypes/1o68O/src/ArrowTypes.jl:168
[2] toarrow(x::Char) in ArrowTypes at /Users/eph/.julia/packages/ArrowTypes/1o68O/src/ArrowTypes.jl:181
[3] toarrow(x::Symbol) in ArrowTypes at /Users/eph/.julia/packages/ArrowTypes/1o68O/src/ArrowTypes.jl:203
[4] toarrow(x::AbstractSet) in ArrowTypes at /Users/eph/.julia/packages/ArrowTypes/1o68O/src/ArrowTypes.jl:214
[5] toarrow(x::Base.UUID) in ArrowTypes at /Users/eph/.julia/packages/ArrowTypes/1o68O/src/ArrowTypes.jl:229
[6] toarrow(x) in ArrowTypes at /Users/eph/.julia/packages/ArrowTypes/1o68O/src/ArrowTypes.jl:83
@quinnj
Copy link
Member

quinnj commented Jun 4, 2021

Yes; this was definitely the plan once ArrowTypes got registered; just forgot to go back and do the actual decoupling.

@ericphanson
Copy link
Member Author

Ah ok, makes sense! I can make a PR if that would help. Would you commit a Manifest and dev ArrowTypes in Arrow? (So you can jointly develop them). Or no manifest and treat them as fully separate packages?

@quinnj
Copy link
Member

quinnj commented Jun 5, 2021

I'd say just treat them as separate packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants