feat(r): Add ability to deterministically run a finalizer on an array stream #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 88.30% 88.35% +0.04%
==========================================
Files 60 60
Lines 8981 9016 +35
==========================================
+ Hits 7931 7966 +35
Misses 1050 1050
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paleolimbot
added a commit
to apache/arrow-adbc
that referenced
this pull request
May 24, 2023
…enience functions (#706) After #693 and apache/arrow-nanoarrow#196 we have enough lifecycle management to implement some convenience methods. This makes it about 1000% easier to play around with queries. An example with the SQLite driver: ``` r library(adbcdrivermanager) temp <- tempfile() db <- adbc_database_init(adbcsqlite::adbcsqlite(), uri = temp) write_adbc(data.frame(x = 1:10), db, "some_table") read_adbc(db, "SELECT * from some_table") |> tibble::as_tibble() #> # A tibble: 10 × 1 #> x #> <dbl> #> 1 1 #> 2 2 #> 3 3 #> 4 4 #> 5 5 #> 6 6 #> 7 7 #> 8 8 #> 9 9 #> 10 10 execute_adbc( db, "UPDATE some_table SET x = ? WHERE x >= ?", bind = data.frame(123, 8) ) read_adbc(db, "SELECT * from some_table") |> tibble::as_tibble() #> # A tibble: 10 × 1 #> x #> <dbl> #> 1 1 #> 2 2 #> 3 3 #> 4 4 #> 5 5 #> 6 6 #> 7 7 #> 8 123 #> 9 123 #> 10 123 ``` <sup>Created on 2023-05-24 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the finalizer would only run on garbage collection. For ADBC, we want that to be deterministic so that we can close a statement/connection predictably.