Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ArrowArrayViewListChildOffset() #197

Merged
merged 3 commits into from
May 20, 2023

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented May 19, 2023

Similar to what exists for Dense/Sparse Union. This would at least be useful in the ADBC library, which currently provides its own implementation

apache/arrow-adbc#679 (comment)

@codecov-commenter
Copy link

Codecov Report

Merging #197 (3f17f4b) into main (dea6733) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   88.35%   88.34%   -0.02%     
==========================================
  Files          60       60              
  Lines        9016     9024       +8     
==========================================
+ Hits         7966     7972       +6     
- Misses       1050     1052       +2     
Impacted Files Coverage Δ
src/nanoarrow/array_inline.h 89.83% <75.00%> (-0.23%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Seems reasonable and useful to me!

@paleolimbot paleolimbot changed the title Implement ListChildOffset function feat: Implement ListChildOffset function May 20, 2023
@paleolimbot paleolimbot changed the title feat: Implement ListChildOffset function feat: Add ArrowArrayViewListChildOffset() May 20, 2023
@paleolimbot paleolimbot merged commit 2a11bdb into apache:main May 20, 2023
23 checks passed
@WillAyd WillAyd deleted the add-list-offset branch May 22, 2023 16:45
lidavidm pushed a commit to apache/arrow-adbc that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants