Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(r): Fix convert_array_stream() for non-record batch stream with zero batches #212

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Jun 7, 2023

Looks like a copy-pastie.

@krlmlr krlmlr requested a review from paleolimbot June 7, 2023 20:35
@codecov-commenter
Copy link

Codecov Report

Merging #212 (b16130e) into main (47a4ef4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   87.87%   87.89%   +0.01%     
==========================================
  Files          60       60              
  Lines        9249     9249              
==========================================
+ Hits         8128     8129       +1     
+ Misses       1121     1120       -1     
Impacted Files Coverage Δ
r/R/convert-array-stream.R 96.77% <100.00%> (+3.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this!

@paleolimbot paleolimbot changed the title chore: Remove duplicate branch fix(r): Fix convert_array_stream() for non-record batch stream with zero batches Jun 8, 2023
@paleolimbot paleolimbot merged commit e9b8ad9 into apache:main Jun 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants