fix(r): Warn for possibly out of range int64 -> double conversions #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like I had left this as a TODO after my initial push to get most conversions implemented. The idea is to warn when converting very large int64/uint64 values to double. This an important case to warn for because double is the default conversion from int64 and values that won't (or might not) roundtrip back to int64 are important to warn about. See #293 implementing a safer conversion.
Created on 2023-09-01 with reprex v2.0.2