Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(r): Ensure ordered is reflected in na_dictionary() #299

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

paleolimbot
Copy link
Member

Closes #296.

library(nanoarrow)

arrow::as_data_type(na_dictionary(na_string(), ordered = FALSE))
#> DictionaryType
#> dictionary<values=string, indices=int32>
arrow::as_data_type(na_dictionary(na_string(), ordered = TRUE))
#> DictionaryType
#> dictionary<values=string, indices=int32>

arrow::as_data_type(
  infer_nanoarrow_schema(factor(letters[1:5], ordered = TRUE))
)
#> DictionaryType
#> dictionary<values=string, indices=int32>
arrow::as_data_type(
  infer_nanoarrow_schema(factor(letters[1:5], ordered = FALSE))
)
#> DictionaryType
#> dictionary<values=string, indices=int32>

Created on 2023-09-18 with reprex v2.0.2

@codecov-commenter
Copy link

Codecov Report

Merging #299 (1859a95) into main (804630d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   86.97%   86.93%   -0.04%     
==========================================
  Files          69       66       -3     
  Lines       10553    10201     -352     
==========================================
- Hits         9178     8868     -310     
+ Misses       1375     1333      -42     
Files Changed Coverage Δ
r/R/type.R 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paleolimbot paleolimbot merged commit 2060685 into apache:main Sep 19, 2023
13 checks passed
@paleolimbot paleolimbot deleted the r-ordered branch September 19, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument ordered in na_dictionary is always ignored
2 participants