Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn for timestamp types #1086

Closed
alamb opened this issue Dec 22, 2021 · 1 comment · Fixed by #1095
Closed

implement eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn for timestamp types #1086

alamb opened this issue Dec 22, 2021 · 1 comment · Fixed by #1095
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Dec 22, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We are tryng to use the new dynamic comparison kernels added in #858 / #843 by @jimexist
in DataFusion: apache/datafusion#1475

It turns out that Datafusion also supports operations on the timestamp / time arrays as well so we can't use the dynamic kernels (yet)

Describe the solution you'd like
Add support for the following types to eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn (there is one macro needed):

DataType::Timestamp(TimeUnit::Nanosecond, _) => {
DataType::Timestamp(TimeUnit::Microsecond, _) => {
DataType::Timestamp(TimeUnit::Millisecond, _) => {
DataType::Timestamp(TimeUnit::Second, _) => {
DataType::Date32 => {
DataType::Date64 => {

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

@alamb alamb added enhancement Any new improvement worthy of a entry in the changelog arrow Changes to the arrow crate labels Dec 22, 2021
@alamb alamb added the good first issue Good for newcomers label Dec 22, 2021
@alamb
Copy link
Contributor Author

alamb commented Dec 22, 2021

I think this could be accomplished by implementing the appropriate types in macro_rules! typed_compares { in https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/comparison.rs#L1109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant