Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add with_datetime_format() to CSV WriterBuilder #1272

Closed
rjnanderson opened this issue Feb 4, 2022 · 0 comments · Fixed by #1347
Closed

Add with_datetime_format() to CSV WriterBuilder #1272

rjnanderson opened this issue Feb 4, 2022 · 0 comments · Fixed by #1347
Labels
arrow Changes to the arrow crate bug

Comments

@rjnanderson
Copy link

rjnanderson commented Feb 4, 2022 •
edited

Describe the bug
Can't override csv WriterBuilder's default datetime_format because this is missing:

impl WriterBuilder {
. . .
/// Set the CSV file's datetime format
pub fn with_datetime_format(mut self, format: String) -> Self {
self.datetime_format = Some(format);
self
}
. . .

Additional context
version 8.0.0
@rjnanderson rjnanderson added the bug label Feb 4, 2022
@gsserge gsserge mentioned this issue Feb 20, 2022
Merged
@alamb alamb added the arrow Changes to the arrow crate label Mar 3, 2022
@alamb alamb changed the title csv impl WriterBuilder has no with_datetime_format() Add with_datetime_format() to CSV WriterBuilder Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add with_datetime_format to csv WriterBuilder
2 participants
@alamb @rjnanderson