Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: bit_chunk_iterator #1294

Closed
nevi-me opened this issue Feb 10, 2022 · 1 comment · Fixed by #1297
Closed

Test failure: bit_chunk_iterator #1294

nevi-me opened this issue Feb 10, 2022 · 1 comment · Fixed by #1297
Labels

Comments

@nevi-me
Copy link
Contributor

nevi-me commented Feb 10, 2022

Describe the bug
The test_unaligned_bit_chunk_iterator() test fails to run on aarch64 because of an assertion assert!(ALIGNMENT > 64). There are several platforms that support 64-bit or lower alignment, and this assertion will also fail on them.

To Reproduce
Steps to reproduce the behavior:

Run arrow tests with arm, aarch64 or other platform with a lower alignment than the assertion

Expected behavior
A clear and concise description of what you expected to happen.

Not sure of what the implication of > 64 alignment is, as I haven't been following the codebase

Additional context
Add any other context about the problem here.

Here's the alignment for aarch64 https://github.com/apache/arrow-rs/blob/master/arrow/src/alloc/alignment.rs#L119. CC @tustvold from #1228

@nevi-me nevi-me added the bug label Feb 10, 2022
@tustvold
Copy link
Contributor

tustvold commented Feb 10, 2022

IIRC this will just impact the correctness of the test and not the code, but I'll take a look and get a fix in. Thanks for reporting 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants