Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV Writer::new to accept delimiter and make WriterBuilder::build use it #1328

Closed
gsserge opened this issue Feb 17, 2022 · 1 comment · Fixed by #1342
Closed

Fix CSV Writer::new to accept delimiter and make WriterBuilder::build use it #1328

gsserge opened this issue Feb 17, 2022 · 1 comment · Fixed by #1342
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers

Comments

@gsserge
Copy link
Contributor

gsserge commented Feb 17, 2022

Discovered in #1324 (comment)

The delimiter can be correctly configured via WriterBuilder. WriterBuilder::build() constructs the Writer in-line and does not use Write::new().

Currently, Write::new() does not have the ability to configure the delimiter. The function should be changed to accept it as a parameter, and then WriterBuilder::build() should use Write::new() instead of duplicating the code. The delimiter field in struct Writer can be removed, because it can only be configured when creating Writer.

@gsserge gsserge added the bug label Feb 17, 2022
@alamb alamb added arrow Changes to the arrow crate good first issue Good for newcomers labels Feb 17, 2022
@HaoYang670
Copy link
Contributor

HaoYang670 commented Feb 18, 2022

Just a small nit. The title should be Fix CSV not Fix cvs.
Also, same mistake is in the title of #1327

@gsserge gsserge changed the title Fix cvs Writer::new to accept delimiter and make WriterBuilder::build use it Fix csv Writer::new to accept delimiter and make WriterBuilder::build use it Feb 18, 2022
@alamb alamb changed the title Fix csv Writer::new to accept delimiter and make WriterBuilder::build use it Fix CSV Writer::new to accept delimiter and make WriterBuilder::build use it Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants