Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dictionary array in C data interface #1397

Closed
sunchao opened this issue Mar 4, 2022 · 1 comment · Fixed by #1407
Closed

Support dictionary array in C data interface #1397

sunchao opened this issue Mar 4, 2022 · 1 comment · Fixed by #1407
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@sunchao
Copy link
Member

sunchao commented Mar 4, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently it seems the Arrow FFI interface doesn't support dictionary yet. Even though the field exists in FFI_ArrowArray, it is never assigned or used.

Unlike the C++ implementation, ArrayData doesn't have a dictionary field either.

Describe the solution you'd like

I haven't looked closely, but I think roughly we should have dictionary in ArrayData first? after that exporting it via the FFI will be straightforward.

Describe alternatives you've considered
N/A

Additional context
N/A

@sunchao sunchao added the enhancement Any new improvement worthy of a entry in the changelog label Mar 4, 2022
@sunchao
Copy link
Member Author

sunchao commented Mar 4, 2022

DictionaryArray also needs change as it is currently not C data interface compatible - when exporting to ArrayData it needs to populate the dictionary field in the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant