Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A small mistake in the doc of GenericBinaryArray::take_iter_unchecked #1454

Closed
HaoYang670 opened this issue Mar 16, 2022 · 0 comments · Fixed by #1491
Closed

A small mistake in the doc of GenericBinaryArray::take_iter_unchecked #1454

HaoYang670 opened this issue Mar 16, 2022 · 0 comments · Fixed by #1491
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
https://github.com/apache/arrow-rs/blob/master/arrow/src/array/array_binary.rs#L216

    /// caller must ensure that the offsets in the iterator are less than the array len()

not offsets, but indexes
@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Mar 16, 2022
@HaoYang670 HaoYang670 mentioned this issue Mar 27, 2022
Merged
@alamb alamb added documentation Improvements or additions to documentation arrow Changes to the arrow crate and removed enhancement Any new improvement worthy of a entry in the changelog labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update doc of array_binary and array_string HaoYang670/arrow-rs
2 participants
@alamb @HaoYang670