Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIMD support for the length kernel #1489

Closed
HaoYang670 opened this issue Mar 26, 2022 · 1 comment
Closed

Add SIMD support for the length kernel #1489

HaoYang670 opened this issue Mar 26, 2022 · 1 comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We could calculate offset[1 ..] - offset[.. offset.len()] by simd.

Describe the solution you'd like

  1. simd support for length kernel
  2. some benchmark results.
@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Mar 26, 2022
@jhorstmann
Copy link
Contributor

The compiler should be able to autovectorize the existing length kernel, at least it does in a smaller example: https://rust.godbolt.org/z/7sjrrfxqf

If this does not happen in the actual arrow kernel then we probably need to investigate whether MutableBuffer::from_trusted_len_iter somehow prevents that optimization.

@alamb alamb added the arrow Changes to the arrow crate label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

3 participants