Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement size_hint and ExactSizedIterator for DecimalArray #1505

Closed
alamb opened this issue Mar 29, 2022 · 0 comments · Fixed by #1506
Closed

Implement size_hint and ExactSizedIterator for DecimalArray #1505

alamb opened this issue Mar 29, 2022 · 0 comments · Fixed by #1506
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Mar 29, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I was doing some small cleanups in DataFusion apache/datafusion#2107 and noticed that the DecimalArray iterators do not report their exact size. The exact size is used in several places for optimizations in Arrow

Describe the solution you'd like
Implement size_hint and ExactSizedIterator for DecimalArray

Describe alternatives you've considered
N/A

Additional context
Cleanup PR apache/datafusion#2107
@alamb alamb added enhancement Any new improvement worthy of a entry in the changelog arrow Changes to the arrow crate labels Mar 29, 2022
@alamb alamb mentioned this issue Mar 29, 2022
Merged
@alamb alamb changed the title Implement size_hint and ExactSizedIterator for DecimalArray Implement size_hint and ExactSizedIterator for DecimalArray Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement size_hint and ExactSizedIterator for DecimalArray alamb/arrow-rs
1 participant
@alamb