Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayData Equality Slice Iterator #1600

Closed
tustvold opened this issue Apr 20, 2022 · 0 comments · Fixed by #3198
Closed

ArrayData Equality Slice Iterator #1600

tustvold opened this issue Apr 20, 2022 · 0 comments · Fixed by #3198
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted performance

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

A lot of the ArrayData equality implementation iterate through row-wise in the event of nulls, it would be advantageous to instead iterate over valid ranges, for example, using SlicesIterator. I originally planned to do this as part of #1589 but that PR already is rather large so creating as ticket and will follow up later

Describe the solution you'd like

Should use SlicesIterator to amortize the cost of performing equality comparisons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant