Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate_nested_dictionary_case integration test failure for Rust cases #1635

Closed
viirya opened this issue May 1, 2022 · 0 comments · Fixed by #1636
Closed

Fix generate_nested_dictionary_case integration test failure for Rust cases #1635

viirya opened this issue May 1, 2022 · 0 comments · Fixed by #1636
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented May 1, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Part of #1404. This is for generate_nested_dictionary_case, Rust producing, Rust consuming case.

Currently running archery --debug integration --run-flight --with-cpp=false --with-rust=true, you will get some errors:

dictionary value type: List(Field { name: "str_dict", data_type: Dictionary(Int8, Utf8), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: None })
Error: JsonError("Unable to find any dictionaries for field Field { name: \"str_dict\", data_type: Dictionary(Int8, Utf8), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: None }")

Note: for other cases like C++ producing, Rust consuming case by enabling it with --with-cpp=true, I've not figured out how to fix it yet. The IPC format seems inconsistent. I will open another issue to deal with it.

Describe the solution you'd like
Running archery --debug integration --run-flight --with-cpp=false --with-rust=true should pass with 0 failure.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label May 1, 2022
@alamb alamb changed the title Fix generate_nested_dictionary_case integration test failure for Rust cases Fix generate_nested_dictionary_case integration test failure for Rust cases May 12, 2022
@alamb alamb added the arrow Changes to the arrow crate label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants