Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leaf_columns argument to ArrowReader::get_record_reader_by_columns #1653

Closed
tustvold opened this issue May 5, 2022 · 0 comments · Fixed by #1716
Closed

Add leaf_columns argument to ArrowReader::get_record_reader_by_columns #1653

tustvold opened this issue May 5, 2022 · 0 comments · Fixed by #1716
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

tustvold commented May 5, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

ArrowReader::get_schema_by_columns has a leaf_columns argument that switches between selecting between the indexes of leaf columns, and the indexes of the root schema element.

This is helpful because not only does it highlight to the end-user that there is a distinction, but depending on the use-case the user might want either behaviour.

Describe the solution you'd like

Add a leaf_columns field to ArrowReader::get_record_reader_by_columns

Describe alternatives you've considered

We could not do this

Additional context

apache/datafusion#2453

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label May 5, 2022
@alamb alamb added the parquet Changes to the parquet crate label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants