-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support write page index #1777
Comments
One thing I stumbled across whilst reviewing the read side, is that the ColumnIndex has an implicit assumption that semantic records don't span page boundaries. That is the first repetition level of each page is 0. I think we may need to enforce this when writing file with a column index. https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L920 |
I think it should be considered a bug if part of a record is recorded over 2 page boundaries. It would create ambiguity on the record, and force a reader to potentially read the page in reverse to find the start of the record. Great catch! |
@tustvold |
After go through current write path in the arrow-rs, I think we need to do some minor refactor to collect and write Page Index to the tail of the parquet file. |
|
In the current parquet writer for rust version: before flush the filemetadata to the disk, we should edit the column chunk metadata and add the index offset and index length metadata. |
this issue can't be closed. |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)
From the issue #1705, the feature page index is important for arrow-rs reading and writing.
@Ted-Jiang is working on the reading path for the page index #1749.
I will work on the writing path for page index in the parquet-rs.
@alamb
@tustvold
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: