Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON reader does not implement iterator #193

Closed
alamb opened this issue Apr 26, 2021 · 6 comments · Fixed by #451
Closed

JSON reader does not implement iterator #193

alamb opened this issue Apr 26, 2021 · 6 comments · Fixed by #451
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Apr 26, 2021

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11823

https://docs.rs/arrow/3.0.0/arrow/json/reader/struct.Reader.html does not implement the iterator trait even though it implements next.
@alamb alamb added the arrow Changes to the arrow crate label Apr 26, 2021
@domoritz domoritz mentioned this issue May 7, 2021
Closed
@domoritz
Copy link
Member

domoritz commented May 7, 2021

The CSV has an iterator in

arrow-rs/arrow/src/csv/reader.rs

Line 372 in b76e8c9

impl<R: Read> Iterator for Reader<R> {
.

@alamb
Copy link
Contributor Author

alamb commented May 7, 2021

There is no reason I know of that this should not be done

@domoritz
Copy link
Member

domoritz commented May 7, 2021

Is this a bug or an enhancement request? I'm not sure how I would use the reader to read all batches without the iterator.

@alamb
Copy link
Contributor Author

alamb commented May 7, 2021 •
edited
Loading

Is this a bug or an enhancement request? I'm not sure how I would use the reader to read all batches without the iterator.

It can be whatever you want :) I'll start with bug and we can change it if you want. Please feel free to contribute a PR

@alamb alamb added bug good first issue Good for newcomers labels May 7, 2021
@alamb
Copy link
Contributor Author

alamb commented May 7, 2021

I think this is also a good first issue as well

@domoritz
Copy link
Member

domoritz commented May 7, 2021

@erichutchins do you want to look into this to fix domoritz/json2parquet#1?

@LaurentMazare LaurentMazare mentioned this issue Jun 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement the Iterator trait for the json Reader. LaurentMazare/arrow-rs
2 participants
@alamb @domoritz