Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect null_count of DictionaryArray #1962

Closed
viirya opened this issue Jun 29, 2022 · 2 comments
Closed

Incorrect null_count of DictionaryArray #1962

viirya opened this issue Jun 29, 2022 · 2 comments
Labels
arrow Changes to the arrow crate

Comments

@viirya
Copy link
Member

viirya commented Jun 29, 2022

Describe the bug

null_count of DictionaryArray calls the default implementation which gets null count of its data member. So basically it looks at the null count of keys. If a corresponding value of a key is null, null_count cannot get correct null count.

is_null and is_valid also have same issue.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.
@viirya viirya added the bug label Jun 29, 2022
@viirya viirya mentioned this issue Jun 29, 2022
Closed
@viirya viirya closed this as completed Jun 29, 2022
@alamb alamb changed the title Incorrect null_count of DictionaryArray Incorrect null_count of DictionaryArray Jul 7, 2022
@alamb alamb added arrow Changes to the arrow crate and removed bug labels Jul 7, 2022
@alamb
Copy link
Contributor

alamb commented Jul 7, 2022 •
edited
Loading

Removing bug label as it was determined that this was not a bug - #1963 (comment)

@viirya
Copy link
Member Author

viirya commented Jul 7, 2022

Yea, thanks @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Dictionary null_count viirya/arrow-rs
2 participants
@viirya @alamb