Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DictionaryArray in Like Kernels #1975

Closed
tustvold opened this issue Jun 30, 2022 · 2 comments · Fixed by #3197
Closed

Support DictionaryArray in Like Kernels #1975

tustvold opened this issue Jun 30, 2022 · 2 comments · Fixed by #3197
Assignees
@psvri
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Noticed whilst implementing apache/datafusion#2808, we currently lack support for dictionary arrays in the like comparison kernels

Describe the solution you'd like

We should support dictionary arrays in these kernels

Describe alternatives you've considered

We could not support them

Additional context
None
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jun 30, 2022
@viirya viirya mentioned this issue Jun 30, 2022
Closed
11 tasks
@alamb alamb added good first issue Good for newcomers arrow Changes to the arrow crate labels Jul 8, 2022
@psvri
Copy link
Contributor

psvri commented Aug 20, 2022 •
edited

Hello,

I would like to pick this up if no one else is working on it.

@tustvold
Copy link
Contributor Author

That would be brilliant, you may be able to make use of the new ArrayAccessor plumbing to avoid code duplication

@psvri psvri mentioned this issue Aug 25, 2022
Merged
This was referenced Nov 25, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psvri psvri

Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add _dyn kernels of like, ilike, nlike, nilike kernels for dictionary support viirya/arrow-rs
3 participants
@alamb @tustvold @psvri