Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of bound reads in chunk iterator #198

Closed
alamb opened this issue Apr 26, 2021 · 1 comment · Fixed by #416
Closed

Out of bound reads in chunk iterator #198

alamb opened this issue Apr 26, 2021 · 1 comment · Fixed by #416
Labels
arrow Changes to the arrow crate bug security

Comments

@alamb
Copy link
Contributor

alamb commented Apr 26, 2021

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11865

There is a read_unaligned of a pointer offseted by index + 1 whose corresponding slice is only valid up to index - X, where X depends on the iterators' offset.

@alamb alamb added the arrow Changes to the arrow crate label Apr 26, 2021
@alamb
Copy link
Contributor Author

alamb commented Apr 26, 2021

Comment from Jörn Horstmann(jhorstmann) @ 2021-03-15T14:01:41.332+0000:

Good catch, this really looks suspect now. I think that second read could be replaced with reading a single byte since the bit_offset is guaranteed to be in 0..8, meaning we need at most one byte to fill in the remaining bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants