Several Builder::append methods returning results even though they are infallible

[jhorstmann]

Which part is this question about

I noticed that a lot of the append or append_null methods in builders are always returning Ok(()). There are only very few builders that can legitimately return an error, for example dictionaries on overflow or some validation for decimals.

Describe your question

I'm wondering whether this is a design decision, to make all builder apis seem more consistent or if it is maybe a leftover from a time when we had fallible allocation logic.

Additional context

Although the compiler should be able to optimize these away, there could still be a performance impact in some cases. It also makes it more difficult to use these builders in an infallible context.

[HaoYang670]

I had the same concern when updating the binary and list builders

[tustvold]

I would support changing this. Could possibly be combined with #2054