Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get MIRI running again #224

Closed
alamb opened this issue Apr 26, 2021 · 1 comment
Closed

Get MIRI running again #224

alamb opened this issue Apr 26, 2021 · 1 comment
Labels
arrow Changes to the arrow crate security

Comments

@alamb
Copy link
Contributor

alamb commented Apr 26, 2021

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11713

Rust's MIRI https://github.com/rust-lang/miri can help detect logical errors in programs

The Rust arrow implementation now runs the MIRI checks as part of CI thanks to [~vertexclique] but it does not pass cleanly yet

For example:
https://github.com/apache/arrow/pull/9535/checks?check_run_id=1941313240

{code}

Compiling criterion v0.3.4
Compiling h2 v0.3.0
Compiling tower v0.4.5
Compiling hyper v0.14.4
error[E0463]: can't find crate for tracing
--> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.14.4/src/lib.rs:68:1
|
68 | extern crate tracing;
| ^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error
{code}

Previously MIRI ran but the check failed in FFI somewhere

Help wanted!

@alamb alamb added the arrow Changes to the arrow crate label Apr 26, 2021
@alamb
Copy link
Contributor Author

alamb commented May 12, 2021

MIRI is compiling again - see https://github.com/apache/arrow-rs/runs/2552518448?check_suite_focus=true so closing this issue

However, it still reports errors -- which is tracked by #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate security
Projects
None yet
Development

No branches or pull requests

2 participants