Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Decimal Array using const_generic #2384

Closed
3 tasks done
HaoYang670 opened this issue Aug 9, 2022 · 3 comments
Closed
3 tasks done

Rewrite Decimal Array using const_generic #2384

HaoYang670 opened this issue Aug 9, 2022 · 3 comments
Labels
arrow Changes to the arrow crate

Comments

@HaoYang670
Copy link
Contributor

HaoYang670 commented Aug 9, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Why I prefer using const_generic on Decimal?

Will the rewriting leads to many API changes?
Yes, But for users, the answer is no. Because this is just an internal refactor.

Checked List

Describe alternatives you've considered
We could not do this.

Additional context
Related to #2362 and #2274.

@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Aug 9, 2022
@liukun4515
Copy link
Contributor

@HaoYang670
The refactor is reasonable for me.

@liukun4515
Copy link
Contributor

Do you want to do all the checklist in the one pull request?

@HaoYang670
Copy link
Contributor Author

HaoYang670 commented Aug 9, 2022

Do you want to do all the checklist in the one pull request?

No.
In the first PR, I will update BasicDecimal and BasicDecimalArray. I tried to make change step by step, but I have to update these 2 in one PR 😅.

@HaoYang670 HaoYang670 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2022
@alamb alamb added arrow Changes to the arrow crate and removed enhancement Any new improvement worthy of a entry in the changelog labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

No branches or pull requests

3 participants