Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the flight.proto and fix schema to SchemaResult #2571

Closed
liukun4515 opened this issue Aug 24, 2022 · 2 comments · Fixed by #2586
Closed

update the flight.proto and fix schema to SchemaResult #2571

liukun4515 opened this issue Aug 24, 2022 · 2 comments · Fixed by #2586
Assignees
@liukun4515
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate bug

Comments

@liukun4515
Copy link
Contributor

Describe the bug

The issue is described in #2445

How to fix this issue:

  1. update the flight.proto
  2. update the implementation of impl From<SchemaAsIpc<'_>> for SchemaResult { using the ipc format instead of raw flatbuffer

To Reproduce

Expected behavior

Additional context
@liukun4515 liukun4515 added the bug label Aug 24, 2022
@liukun4515 liukun4515 self-assigned this Aug 24, 2022
This was referenced Aug 24, 2022
Closed
Merged
@tustvold tustvold added the arrow-flight Changes to the arrow-flight crate label Sep 8, 2022
@alamb alamb added the arrow Changes to the arrow crate label Sep 16, 2022
@alamb
Copy link
Contributor

alamb commented Sep 16, 2022

Automatically added labels {'arrow'} from #2586

@alamb
Copy link
Contributor

alamb commented Sep 16, 2022

Automatically added labels {'api-change'} from #2586

@alamb alamb added api-change Changes to the arrow API and removed api-change Changes to the arrow API labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liukun4515 liukun4515

Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update flight definitions including backwards-incompatible change to GetSchema liukun4515/arrow-rs
3 participants
@alamb @tustvold @liukun4515