Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace complicated temporal macro with generic functions #2851

Closed
viirya opened this issue Oct 8, 2022 · 0 comments · Fixed by #2850
Closed

Replace complicated temporal macro with generic functions #2851

viirya opened this issue Oct 8, 2022 · 0 comments · Fixed by #2850
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Oct 8, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Temporal kernels use a complicated macro extract_component_from_array which has three different parameter patterns and usage. It is better to rewrite the macro to generic functions.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Oct 8, 2022
@viirya viirya mentioned this issue Oct 8, 2022
Merged
@alamb alamb added the arrow Changes to the arrow crate label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace complicated temporal macro with generic functions viirya/arrow-rs
2 participants
@viirya @alamb