Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 26.0.0 RC1: limit is not applied for multi-column sorts lexsort_to_indices #2990

Closed
alamb opened this issue Oct 31, 2022 · 1 comment · Fixed by #2991
Closed
Labels
arrow Changes to the arrow crate bug

Comments

@alamb
Copy link
Contributor

alamb commented Oct 31, 2022

Describe the bug
Found by @Dandandan and @isidentical while testing the arrow 26.0.0 upgrade in DataFusion

apache/datafusion#4039 (comment)

To Reproduce
Run lexsort_to_indices with a limit on a multi-column sort.

Expected behavior

Additional context
quoting @isidentical:

Probably due to the changes in #2929, where we previously created an array of (&value_indices)[0..len] but now just create it from value_indices directly without any limit (the single-column case is handled separately; and it still respects the limit).

@tustvold authored the PR in question and I approved them so I feel responsible for fixing this

@alamb
Copy link
Contributor Author

alamb commented Oct 31, 2022

Given that this is a regression I think it is a release blocker and I will create a new release candidate with the fix

@alamb alamb added the arrow Changes to the arrow crate label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant