Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to FlightDataEncoder to always send dictionaries #4895

Closed
alexwilcoxson-rel opened this issue Oct 5, 2023 · 2 comments · Fixed by #4896
Closed

Add option to FlightDataEncoder to always send dictionaries #4895

alexwilcoxson-rel opened this issue Oct 5, 2023 · 2 comments · Fixed by #4896
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alexwilcoxson-rel
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Per #3389 dictionaries are not supported over flight and right now they are cast into their underlying value type array.

Describe the solution you'd like
In lieu of the solution described on #3389 to provide initial support for dictionary arrays we can have opt in behavior to always send dictionaries with each record batch, replacing the previous

Describe alternatives you've considered
n/a

Additional context
n/a
@alexwilcoxson-rel alexwilcoxson-rel added the enhancement Any new improvement worthy of a entry in the changelog label Oct 5, 2023
This was referenced Oct 5, 2023
Merged
Open
@tustvold tustvold added the arrow Changes to the arrow crate label Oct 18, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #4896

@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow-flight'} from #4896

@tustvold tustvold added the arrow-flight Changes to the arrow-flight crate label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to FlightDataEncoder to always resend batch dictionaries relativityone/arrow-rs
2 participants
@tustvold @alexwilcoxson-rel