Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FlightSQL] Allow custom commands in get-flight-info #4996

Closed
amartins23 opened this issue Oct 26, 2023 · 2 comments · Fixed by #4997
Closed

[FlightSQL] Allow custom commands in get-flight-info #4996

amartins23 opened this issue Oct 26, 2023 · 2 comments · Fixed by #4997
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@amartins23
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The current FlightSqlService trait allows the implementer to handle custom commands in the DoGet call via do_get_fallback method implementation. However, the corresponding GetFlightInfo call does not allow obtaining tickets for custom commands.

Describe the solution you'd like
Create new methods (with default implementations) in the FlightSqlService trait: get_flight_info_fallback

Describe alternatives you've considered
The alternative is to create a wrapper FlightService implementation that has custom handling, then forwards everything to the existing implementation provided by implementing FlightSqlService.

Additional context
See previous issue #4463.
@amartins23 amartins23 added the enhancement Any new improvement worthy of a entry in the changelog label Oct 26, 2023
@amartins23 amartins23 mentioned this issue Oct 26, 2023
Merged
@tustvold tustvold added the arrow Changes to the arrow crate label Nov 2, 2023
@tustvold
Copy link
Contributor

tustvold commented Nov 2, 2023

label_issue.py automatically added labels {'arrow'} from #4997

@tustvold
Copy link
Contributor

tustvold commented Nov 2, 2023

label_issue.py automatically added labels {'arrow-flight'} from #4997

@tustvold tustvold added the arrow-flight Changes to the arrow-flight crate label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(flight-sql): Allow custom commands in get-flight-info amartins23/arrow-rs
2 participants
@tustvold @amartins23