Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate Using Interleave Kernel for Zip #5097

Open
tustvold opened this issue Nov 18, 2023 · 0 comments
Open

Evaluate Using Interleave Kernel for Zip #5097

tustvold opened this issue Nov 18, 2023 · 0 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently the zip kernel makes use of MutableArrayData. This will work well when the mask contains long runs of true or false values, and when the inputs are not scalar.

Describe the solution you'd like

It is conceivable that constructing an input for the interleave kernel is always faster, but it is also possible a hybrid approach that does the following might be possible:

  • Count bits in mask
  • If less than some threshold set or unset use MutableArrayData
  • Otherwise use interleave kernel

This will involve writing good benchmarks to assess the impact of any change

Describe alternatives you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Development

No branches or pull requests

1 participant