Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListArray equality check may return wrong result #570

Closed
waynexia opened this issue Jul 20, 2021 · 0 comments · Fixed by #571
Closed

ListArray equality check may return wrong result #570

waynexia opened this issue Jul 20, 2021 · 0 comments · Fixed by #571
Labels

Comments

@waynexia
Copy link
Member

Describe the bug
The PartialEq impl on ListArray will ignore some differences.

To Reproduce

This case should fail but not.

Expected behavior
The above case fail.

Additional context
I noticed this from this test case in the master branch, which is wrong but can pass.

I think the root cause is when comparing two list arrays, the children's bitmap were miscalculated leaving the remaining procedure to recognize some differences as null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant