Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error publishing parquet_derive 6.0.0: ^^^ could not find ipc in arrow #833

Closed
alamb opened this issue Oct 17, 2021 · 3 comments · Fixed by #837
Closed

Error publishing parquet_derive 6.0.0: ^^^ could not find ipc in arrow #833

alamb opened this issue Oct 17, 2021 · 3 comments · Fixed by #837
Labels
bug parquet_derive parquet_derive crate

Comments

@alamb
Copy link
Contributor

alamb commented Oct 17, 2021

Describe the bug
I could not publish the 6.0 version of parquet_derive as part of the 6.0.0 release release.

To Reproduce

Run `cargo publish` from the parquet_derive 6.0 source:
(arrow_dev) alamb@ip-172-16-224-193:~/Downloads/apache-arrow-rs-6.0.0/parquet_derive$ cargo publish

Results in this error:

   Compiling arrow v6.0.0
error[E0432]: unresolved import `arrow::ipc`
  --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/parquet-6.0.0/src/arrow/schema.rs:30:12
   |
30 | use arrow::ipc::writer;
   |            ^^^ could not find `ipc` in `arrow`

error[E0433]: failed to resolve: could not find `ipc` in `arrow`
   --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/parquet-6.0.0/src/arrow/schema.rs:189:26
    |
189 |             match arrow::ipc::root_as_message(slice) {
    |                          ^^^ could not find `ipc` in `arrow`

error[E0433]: failed to resolve: could not find `ipc` in `arrow`
   --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/parquet-6.0.0/src/arrow/schema.rs:192:33
    |
192 |                     .map(arrow::ipc::convert::fb_to_schema)
    |                                 ^^^ could not find `ipc` in `arrow`

error[E0433]: failed to resolve: could not find `ipc` in `arrow`
   --> /Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/parquet-6.0.0/src/arrow/schema.rs:218:27
    |
218 |     let data_gen = arrow::ipc::writer::IpcDataGenerator::default();
    |                           ^^^ could not find `ipc` in `arrow`

Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.
error: failed to verify package tarball

Caused by:
  could not compile `parquet` due to 4 previous errors

Expected behavior
Publishing should have happened successfully

Additional context

@alamb alamb added bug parquet_derive parquet_derive crate labels Oct 17, 2021
@houqp
Copy link
Member

houqp commented Oct 17, 2021

it would be helpful to add cargo publish test in the release verification script like what we did with datafusion: https://github.com/apache/arrow-datafusion/blob/a3ffc529dd391ee47380f489be6b7c7c341b3b74/dev/release/verify-release-candidate.sh#L130

@houqp
Copy link
Member

houqp commented Oct 17, 2021

it looks like we need to propagate the new ipc feature gate from arrow to parquet's arrow writer code.

@alamb
Copy link
Contributor Author

alamb commented Oct 18, 2021

Thanks @houqp -- I'll work on it over the next few days if no one else gets a chance beforehand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug parquet_derive parquet_derive crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants