Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Compatibility macros for exported extern template class declarations #15363

Closed
asfimport opened this issue Mar 14, 2017 · 2 comments
Closed
Assignees
Milestone

Comments

@asfimport
Copy link

See all the compiler warnings in our Windows builds

https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/build/1.0.652

Also, consider the hacks we have around gcc/clang disagreement about visibility about the use of extern template:

https://github.com/apache/arrow/blob/master/cpp/src/arrow/array.h#L508

I suspect we may want some macros to help with compiler differences about such issues, possibly to go in https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/visibility.h

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney / @wesm

Note: This issue was originally created as ARROW-627. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
PR: #447

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 447
#447

@asfimport asfimport added this to the 0.3.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants