Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Arrow cpp code does not support power architecture #15509

Closed
asfimport opened this issue Mar 29, 2016 · 6 comments
Closed

Apache Arrow cpp code does not support power architecture #15509

asfimport opened this issue Mar 29, 2016 · 6 comments

Comments

@asfimport
Copy link

Apache Arrow cpp code does not support power architecture.

While building "Apache Arrow" for cpp for power architecture, it throws below error: "c++: error: unrecognized command line option â-msse3â"
Unable to port it for power.

Environment: RHEL 7.2 power and Ubuntu 15.10 power architecture
Reporter: sonali shrivastava
Assignee: Uwe Korn / @xhochy

Original Issue Attachments:

Note: This issue was originally created as ARROW-90. Please see the migration documentation for further details.

@asfimport
Copy link
Author

sonali shrivastava:
Hi,

I was working on this Issue and not able to assign it to myself, I guess due to less permission privilege.

Currently I have fixed this Issue. Please find the details below:

To enable SIMD support(SIMD being feature of best processor) for power architecture for Apache Arrow, needs to replace "sse3" with "altivec" flag in "CMakeLists.txt".
Please find attached patch named "build_powerSupport_patch" for the same to support Apache Arrow cpp for Power Architecture.

Regards,
Sonali Shrivastava
Power Open Source Solutions

@asfimport
Copy link
Author

Kai Zheng / @drankye:

To enable SIMD support(SIMD being feature of best processor) for power architecture for Apache Arrow, needs to replace "sse3" with "altivec" flag in "CMakeLists.txt".
I understand it needs to support power arch, but why it has to replace "sse3" with "altivec"? IMO, this should be done intelligently, switching to the other by detecting the underlying CPU arch, please.

@asfimport
Copy link
Author

Uwe Korn / @xhochy:
See #50 for a proposed patch that will test if the flags can be used. [~sonalinks] Can you please test if that works for you?

@asfimport
Copy link
Author

sonali shrivastava:
Hi Kai Zheng,

Yes, it is not final code commit, it was proposed thing to support "altivec" flag, have not done any code commit yet. Things will be modified later if power support for Apache Arrow is required?
Thank You @xhochy

@asfimport
Copy link
Author

sonali shrivastava:
Hi Uwe L. Korn,

Yes you can add these flags to test for altivec or sse3 support depending on CPU arch and accordingly you can enable support for power and x86.

Request you to please commit my proposed code change to enable "altivec" flag for power support with your flag test code for detecting CPU arch.

Thank You,

@asfimport
Copy link
Author

Wes McKinney / @wesm:
resolved in 79fddd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants