Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] ARROW_BOOST_VENDORED doesn't work properly with ninja build #15911

Closed
asfimport opened this issue Dec 18, 2018 · 1 comment
Closed

[C++] ARROW_BOOST_VENDORED doesn't work properly with ninja build #15911

asfimport opened this issue Dec 18, 2018 · 1 comment
Assignees
Milestone

Comments

@asfimport
Copy link

Not sure if this is a regression, but I found

$ cmake .. -GNinja -DARROW_BOOST_VENDORED=ON
-- Building using CMake version: 3.12.0
-- Arrow version: 0.12.0 (full: '0.12.0-SNAPSHOT')
clang-tidy not found
clang-format found at /usr/bin/clang-format-6.0
infer not found
-- Found cpplint executable at /home/wesm/code/arrow/cpp/build-support/cpplint.py
-- Compiler command: env LANG=C /usr/bin/c++ -v
-- Compiler version: Using built-in specs.
COLLECT_GCC=/usr/bin/c++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 4.8.5-4ubuntu8~14.04.2' --with-bugurl=file:///usr/share/doc/gcc-4.8/README.Bugs --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.8 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.8 --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-libmudflap --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.8-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 4.8.5 (Ubuntu 4.8.5-4ubuntu8~14.04.2) 

-- Compiler id: GNU
Selected compiler gcc 4.8.5
Optional gold linker is buggy, using ld linker instead
Configured for DEBUG build (set with cmake -DCMAKE_BUILD_TYPE={release,debug,...})
-- Build Type: DEBUG
-- BOOST_VERSION: 1.67.0
-- BROTLI_VERSION: v0.6.0
-- DOUBLE_CONVERSION_VERSION: v3.1.1
-- FLATBUFFERS_VERSION: 02a7807dd8d26f5668ffbbec0360dc107bbfabd5
-- GBENCHMARK_VERSION: v1.4.1
-- GFLAGS_VERSION: v2.2.0
-- GLOG_VERSION: v0.3.5
-- GRPC_VERSION: v1.14.1
-- GTEST_VERSION: 1.8.0
-- JEMALLOC_VERSION: 17c897976c60b0e6e4f4a365c751027244dada7a
-- LZ4_VERSION: v1.7.5
-- ORC_VERSION: 1.5.1
-- PROTOBUF_VERSION: v3.6.1
-- RAPIDJSON_VERSION: v1.1.0
-- RE2_VERSION: 2018-10-01
-- SNAPPY_VERSION: 1.1.3
-- THRIFT_VERSION: 0.11.0
-- ZLIB_VERSION: 1.2.8
-- ZSTD_VERSION: v1.3.7
-- Found pthread: /usr/lib/x86_64-linux-gnu/libpthread.so
-- Boost include dir: 
-- Boost libraries: 
Added static library dependency boost_system_static: /home/wesm/code/arrow/cpp/boost-test/boost_ep-prefix/src/boost_ep/stage/lib/libboost_system.a
Added static library dependency boost_filesystem_static: /home/wesm/code/arrow/cpp/boost-test/boost_ep-prefix/src/boost_ep/stage/lib/libboost_filesystem.a
Added static library dependency boost_regex_static: /home/wesm/code/arrow/cpp/boost-test/boost_ep-prefix/src/boost_ep/stage/lib/libboost_regex.a
Added static library dependency double-conversion_static: /home/wesm/code/arrow/cpp/boost-test/double-conversion_ep/src/double-conversion_ep/lib/libdouble-conversion.a
-- double-conversion include dir: /home/wesm/code/arrow/cpp/boost-test/double-conversion_ep/src/double-conversion_ep/include
-- double-conversion static library: /home/wesm/code/arrow/cpp/boost-test/double-conversion_ep/src/double-conversion_ep/lib/libdouble-conversion.a
-- RapidJSON include dir: /home/wesm/code/arrow/cpp/boost-test/src/rapidjson_ep/include
-- Flatbuffers include dir: /home/wesm/code/arrow/cpp/boost-test/flatbuffers_ep-prefix/src/flatbuffers_ep-install/include
-- Flatbuffers compiler: /home/wesm/code/arrow/cpp/boost-test/flatbuffers_ep-prefix/src/flatbuffers_ep-install/bin/flatc
Added static library dependency jemalloc_static: /home/wesm/code/arrow/cpp/boost-test/jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc_pic.a
Added shared library dependency jemalloc_shared: /home/wesm/code/arrow/cpp/boost-test/jemalloc_ep-prefix/src/jemalloc_ep/dist//lib/libjemalloc.so
-- Found hdfs.h at: /home/wesm/code/arrow/cpp/thirdparty/hadoop/include/hdfs.h
-- Found the ZLIB shared library: /usr/lib/x86_64-linux-gnu/libz.so
Added shared library dependency zlib_shared: /usr/lib/x86_64-linux-gnu/libz.so
Added static library dependency snappy_static: /home/wesm/code/arrow/cpp/boost-test/snappy_ep/src/snappy_ep-install/lib/libsnappy.a
Added static library dependency brotli_enc_static: /home/wesm/code/arrow/cpp/boost-test/brotli_ep/src/brotli_ep-install/lib/x86_64-linux-gnu/libbrotlienc.a
Added static library dependency brotli_dec_static: /home/wesm/code/arrow/cpp/boost-test/brotli_ep/src/brotli_ep-install/lib/x86_64-linux-gnu/libbrotlidec.a
Added static library dependency brotli_common_static: /home/wesm/code/arrow/cpp/boost-test/brotli_ep/src/brotli_ep-install/lib/x86_64-linux-gnu/libbrotlicommon.a
Added static library dependency lz4_static: /home/wesm/code/arrow/cpp/boost-test/lz4_ep-prefix/src/lz4_ep/lib/liblz4.a
Added static library dependency zstd_static: /home/wesm/code/arrow/cpp/boost-test/zstd_ep-install/lib/libzstd.a
-- GLOG_CMAKE_CXX_FLAGS:  -ggdb -O0 -fPIC -pthread
-- CMAKE_CXX_FLAGS in glog:  -ggdb -O0 -fPIC -pthread
-- Glog version: v0.3.5
-- Glog include dir: /home/wesm/code/arrow/cpp/boost-test/glog_ep-prefix/src/glog_ep/include
-- Glog static library: /home/wesm/code/arrow/cpp/boost-test/glog_ep-prefix/src/glog_ep/lib/libglog.a
Added static library dependency glog_static: /home/wesm/code/arrow/cpp/boost-test/glog_ep-prefix/src/glog_ep/lib/libglog.a
-- CMAKE_C_FLAGS:  -ggdb -O0   -Wall -msse4.2
-- CMAKE_CXX_FLAGS:   -ggdb -O0  -Wall -msse4.2 
-- Configuring done
-- Generating done
-- Build files have been written to: /home/wesm/code/arrow/cpp/boost-test
12:35 ~/code/arrow/cpp/boost-test  (master)$ ninja arrow_shared
ninja: error: 'boost_ep-prefix/src/boost_ep/stage/lib/libboost_system.a', needed by 'debug/libarrow.so.12.0.0', missing and no known rule to make it

This seems to work fine with using "make"

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney / @wesm

PRs and other links:

Note: This issue was originally created as ARROW-4070. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 3217
#3217

@asfimport asfimport added this to the 0.12.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants